[HttpFoundation] remove deprecated : FlashBag don't implement anymore IteratorAggregate #13258
Conversation
FlorianLB
commented
Jan 4, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | -- |
| License | MIT |
| Doc PR | -- |
|
|
||
| ### HttpFoundation | ||
|
|
||
| * `Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface` don't implement anymore `\IteratorAggregate` interface |
There was a problem hiding this comment.
Should rather say:
Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterfaceno longer implements theIteratorAggregateinterface
There was a problem hiding this comment.
Might be also good to suggest what should be done instead. For example:
Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterfaceno longer implements theIteratorAggregateinterface. Use theall()method instead of iterating over the flash bag.
|
This should also emit a deprecation warning in 2.7, right? |
|
Changelog message improved. |
| * @return \ArrayIterator An \ArrayIterator instance | ||
| */ | ||
| public function getIterator() | ||
| { |
There was a problem hiding this comment.
Can you submit a PR to add a deprecation warning when used in 2.7? And the Changelog should also be updated in 2.7. Thanks.
There was a problem hiding this comment.
@FlorianLB you'll need to rebase this PR. Deprecation warnings were already merged in and it conflicts with yours.
8173a99 to
879d7a4
Compare
|
Changes rebased. |
|
Thank you @FlorianLB. |
…plement anymore IteratorAggregate (FlorianLB) This PR was squashed before being merged into the 3.0-dev branch (closes #13258). Discussion ---------- [HttpFoundation] remove deprecated : FlashBag don't implement anymore IteratorAggregate | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Commits ------- 69a556d [HttpFoundation] remove deprecated : FlashBag don't implement anymore IteratorAggregate