Validator deprecation fixes #13338
Validator deprecation fixes #13338
Conversation
fabpot
commented
Jan 8, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| $this->parseUsingPipe = null === $parseUsingPipe | ||
| ? PHP_VERSION_ID >= 50307 | ||
| : $parseUsingPipe; | ||
| $this->parseUsingPipe = null === $parseUsingPipe ? yes : $parseUsingPipe; |
There was a problem hiding this comment.
yes ? You mean true instead?
90bea09 to
c108d5e
Compare
1159306 to
43b453b
Compare
43b453b to
22b9765
Compare
|
Not WIP anymore, comments welcome. ping @symfony/deciders |
dcceb7f to
66741b0
Compare
…tMessagePluralization() in unit tests
66741b0 to
a34220e
Compare
|
👍 |
This PR was merged into the 2.7 branch. Discussion ---------- Validator deprecation fixes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- a34220e [Validator] always use the lazy loading metadata factory 818ca58 [Validator] removed usage of deprecated getMessageParameters() and getMessagePluralization() in unit tests c6f1f69 [Validator] fixed deprecation notices for BuildViolation() calls in constraints fb3f9d2 [Validator] fixed usage of deprecate Validator features 91606b5 [Validator] removed obsolete code 5aa44ee removed the Validator BC layer for PHP < 5.3.9 a4139c0 removed code for PHP < 5.3.9 6dc8979 bumped min PHP version to 5.3.9
|
@fabpot do we actually need to keep the 2.5 and 2.5-bc API levels ? In all other places, the BC layer is in the new class rather than in a child of the new class. the only reason it has been added in a child in 2.5 is because of the support for old PHP 5.3.x versions forbidding to use a single class. |
|
@stof Indeed, that would make sense. Do you time to work on that? I must admit that I'm a bit tired of my week working on those kind of things. That's exhausting :) |
|
probably not until the weekend next week (unless I work on it on an evening during the next week). I planned to work on documentation for Mink this weekend (and doing non-programming stuff) |
|
@saro0h is going to try to do that this week-end. |