[2.7] adds legacy tests for deprecated configuration keys. #13344
Conversation
hhamon
commented
Jan 9, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
|
Still working on the |
1de2f3f to
b68b147
Compare
| * @dataProvider getFormats | ||
| */ | ||
| public function testLegacyFormResourcesConfigurationKey($format) | ||
| { |
There was a problem hiding this comment.
you are missing the iniSet() call here
There was a problem hiding this comment.
Good catch. Same in the other
08d6fda to
2e03506
Compare
|
Not WIP anymore but trying to figure out why the tests suite segfaults on 5.3.3. |
2e03506 to
814527f
Compare
|
@hhamon Have you tried to relaunch the tests on Travis? Sometimes, it segfaults for no obvious reasons. |
|
just forget about 5.3.3 by rebasing the branch, given the min version has just been bumped to 5.3.9 😄 |
|
Yep! Looks like the rebase did the trick :D |
|
Everything is green and ready for review by @symfony/deciders ;) |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @hhamon. |
|
@hhamon it would also be good to update the configuration files of functional tests in FrameworkBundle and SecurityBundle to stop using the deprecated config keys but migrating them to the new keys instead (I suggest doing it in a separate PR though, as this one is now mergeable given the 2 votes above) |
…s. (hhamon) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] adds legacy tests for deprecated configuration keys. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 814527f [FrameworkBundle] adds legacy tests for deprecated configuration keys. a290286 [TwigBundle] adds legacy tests for deprecated configuration keys.
|
@stof Good catch! I'm on it ;) |
|
@hhamon I just looked at Travis: https://travis-ci.org/symfony/symfony/jobs/46451129#L1758 |
|
See #13349 |