[3.0][Monolog] Remove deprecated interface and deprecated methods #13348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rosier
commented
Jan 9, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| @@ -12,7 +12,7 @@ | |||
| namespace Symfony\Bridge\Monolog; | |||
|
|
|||
| use Monolog\Logger as BaseLogger; | |||
| use Symfony\Component\HttpKernel\Log\LoggerInterface; | |||
| use Psr\Log\LoggerInterface; | |||
There was a problem hiding this comment.
useless given that the base logger (Monolog) already implements PSR-3
|
Current PR has been updated |
| * {@inheritdoc} | ||
| >>>>>>> 2.7 |
There was a problem hiding this comment.
From the PR?
This is also present in https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Monolog/Logger.php#L68
|
Thank you @rosier. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2015
…ted methods (rosier) This PR was squashed before being merged into the 3.0-dev branch (closes #13348). Discussion ---------- [3.0][Monolog] Remove deprecated interface and deprecated methods | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Commits ------- 0fa072c [3.0][Monolog] Remove deprecated interface and deprecated methods
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.