Remove the API version in the validator component #13517
Conversation
fabpot
commented
Jan 25, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13458 |
| License | MIT |
| Doc PR | n/a |
| // The following code must be removed in 3.0 | ||
| $numArgs = func_num_args(); | ||
| if ($numArgs > 3) { | ||
| trigger_error('The '.__METHOD__.' method is deprecated in version 2.5 and will be removed in version 3.0. Use the Symfony\Component\Validator\Validator\ValidatorInterface::validate method instead.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
the method itself is not deprecated. Only the signature with more arguments
|
The RecursiveValidator needs to implement the legacy interface too (which is currently implemented only in the LegacyValidator child class). Otherwise we won't provide the BC layer |
|
The code of the LegacyExecutionContextFactory should also be moved to the code being used. Otherwise we would not be providing a BC layer anymore |
|
@stof the |
|
@saro0h no, it was also used in the 2.5-BC API level (which is removed by this PR). And the goal of this PR should be to merge the 2.5-BC level into the 2.5 one, not to remove it. The 2.5 level alone cannot be used in 2.7 by default, because it is a BC break (the 2.5 API level actually is the 3.0 level, i.e. the new API without the BC layers). The goal of bumping the PHP requirement to 5.3.9 was precisely to be able to use the 2.5-bc layer all the time instead of forcing to choose between 2.4 and 2.5 on old PHP versions |
|
@stof Can you, by any chance, finish this one? |
|
If it can wait until this weekend, yes. I can work on it. |
|
@stof I think it can wait a few days, sure. Thanks. |
|
Any updates in this one? |
|
I haven't worked on it yet (it is still in my TODO list though) |
|
@stof Do you think you will have time soon? |
|
Closing in favor of #14016 |
…o0h, fabpot, stof) This PR was merged into the 2.7 branch. Discussion ---------- Remove the API version in the validator component | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13458 | License | MIT | Doc PR | n/a This completes the work of #13517 Commits ------- 9438206 Complete the removal of API versions in the validator component 75088c0 [Validator] deprecated API version 0c69f69 Removed 2.5 bc layer