Thanks to visit codestin.com
Credit goes to github.com

Skip to content

turned deprecation notices as fatal when running unit tests #13644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

turned deprecation notices as fatal when running unit tests #13644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions autoload.php.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,23 @@ class DeprecationErrorHandler
$class = isset($trace[$i]['object']) ? get_class($trace[$i]['object']) : $trace[$i]['class'];
$method = $trace[$i]['function'];

$type = 0 === strpos($method, 'testLegacy') || 0 === strpos($method, 'provideLegacy') || 0 === strpos($method, 'getLegacy') || strpos($class, '\Legacy') ? 'legacy' : 'remaining';
$deprecationType = 0 === strpos($method, 'testLegacy') || 0 === strpos($method, 'provideLegacy') || 0 === strpos($method, 'getLegacy') || strpos($class, '\Legacy') ? 'legacy' : 'remaining';

if ('legacy' === $type && 0 === (error_reporting() & E_USER_DEPRECATED)) {
@++$deprecations[$type]['Silenced']['count'];
if ('legacy' === $deprecationType && 0 === (error_reporting() & E_USER_DEPRECATED)) {
@++$deprecations[$deprecationType]['Silenced']['count'];
} else {
@++$deprecations[$type][$msg]['count'];
@++$deprecations[$type][$msg][$class.'::'.$method];
@++$deprecations[$deprecationType][$msg]['count'];
@++$deprecations[$deprecationType][$msg][$class.'::'.$method];
}
} else {
$type = 'other';
@++$deprecations[$type][$msg]['count'];
$deprecationType = 'other';
@++$deprecations[$deprecationType][$msg]['count'];
}
++$deprecations[$deprecationType.'Count'];

if ('legacy' !== $deprecationType) {
return PHPUnit_Util_ErrorHandler::handleError($type, $msg, $file, $line, $context);
}
++$deprecations[$type.'Count'];
};
$oldErrorHandler = set_error_handler($deprecationHandler);

Expand Down
5 changes: 1 addition & 4 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@
bootstrap="autoload.php.dist"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>

<ini name="error_reporting" value="-1"/>
<ini name="intl.default_locale" value="en"/>
<ini name="intl.error_level" value="0"/>
<ini name="memory_limit" value="-1"/>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bridge/Doctrine/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="Tests/bootstrap.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bridge/Monolog/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bridge/Propel1/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing this entirely from the phpunit config (as done before the change avoiding deprecation failures). What do you think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great to set the expectation here, code should work fine with the highest level of error reporting (it was unsafe to rely on the PHP setting IMO).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit better than implicite here for me also

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the default value that phpunit sets anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not: phpunit just keeps values from php.ini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I just tested it. It uses whatever is configured in your own php.ini which by default probably does not enable all errors because PHPs default is not so strict. So I agree it should be set explicitly to -1.

</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bridge/ProxyManager/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bridge/Twig/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bundle/DebugBundle/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bundle/FrameworkBundle/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bundle/SecurityBundle/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bundle/TwigBundle/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Bundle/WebProfilerBundle/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/BrowserKit/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/ClassLoader/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Config/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Console/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/CssSelector/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Debug/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/DependencyInjection/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/DomCrawler/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/EventDispatcher/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/ExpressionLanguage/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Filesystem/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Finder/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Form/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/HttpFoundation/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/HttpKernel/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Intl/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Locale/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/OptionsResolver/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Process/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/PropertyAccess/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Routing/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
4 changes: 1 addition & 3 deletions src/Symfony/Component/Security/Acl/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
bootstrap="vendor/autoload.php"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
<!-- php -r 'echo -1 & ~E_USER_DEPRECATED;' -->
<ini name="error_reporting" value="-16385"/>
<ini name="error_reporting" value="-1" />
</php>

<testsuites>
Expand Down
Loading