[VarDumper] Add casters for Reflection* classes #14080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $a[$p.'typeHint'] = 'callable'; | ||
| } elseif ($v = $c->getClass()) { | ||
| $a[$p.'typeHint'] = $v->name; | ||
| } |
There was a problem hiding this comment.
should we already add the support for scalar typehints here for PHP 7 (with a method_exists check like for isCallable) ?
There was a problem hiding this comment.
Do you know what will be the new methods?
There was a problem hiding this comment.
Looking at the PHP source, scalar typehints are not yet exposed through reflection because there is a pending discussion about the way to expose typehints in a unified way (same for return types). So it is not yet possible to handle this
|
Your test for ReflectionClass need to be adapted because different PHP versions have different methods (PHP 5.3 does not have trait-related methods for instance) |
f9d22ec to
c0e127f
Compare
|
Right, updated! |
4f5d409 to
d125692
Compare
|
PR rebased and ready |
|
👍 |
c67c521 to
cb7b03e
Compare
cb7b03e to
64d6e76
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 1, 2015
…as-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Add casters for Reflection* classes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Will need a rebase on top of #14079 and #14077 to be mergeable/green. Commits ------- 64d6e76 [VarDumper] Add casters for Reflection* classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need a rebase on top of #14079 and #14077 to be mergeable/green.