remove useless tests that fail in php 7 #14088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,16 +67,6 @@ protected function tearDown() | |||
| } | |||
|
|
|||
| /** | |||
| * @expectedException \PHPUnit_Framework_Error | |||
| */ | |||
| public function testChoicesOptionExpectsArray() | |||
There was a problem hiding this comment.
This test will be totally different in 2.7 anyway with the changes to Choice type.
|
why not skip these tests in PHP7 instead ? |
|
why keep them? |
|
👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2015
This PR was merged into the 2.3 branch. Discussion ---------- remove useless tests that fail in php 7 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 for Security and Form component | License | MIT | Doc PR | - `@expectedException \PHPUnit_Framework_Error` doesn't catch php fatal errors for wrong types in php 7. But these test are also pretty useless anyway. Then we would have to add a lot of tests for all arguments that are typehinted. Let's just remove these tests. Commits ------- 59cab27 remove useless tests that fail in php 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@expectedException \PHPUnit_Framework_Errordoesn't catch php fatal errors for wrong types in php 7. But these test are also pretty useless anyway. Then we would have to add a lot of tests for all arguments that are typehinted. Let's just remove these tests.