Removed deprecations in Filesystem component #14145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dosten
commented
Mar 31, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -479,9 +477,6 @@ public function dumpFile($filename, $content, $mode = 0666) | |||
| } | |||
|
|
|||
| $this->rename($tmpFile, $filename, true); | |||
| if (null !== $mode) { | |||
| $this->chmod($filename, $mode); | |||
There was a problem hiding this comment.
Looks like we missed triggering a deprecation notice here in 2.7?
There was a problem hiding this comment.
Yes, you are right, in what branch must be applied a patch for this?
There was a problem hiding this comment.
The default value of the $mode param is 0666, so the error will be triggered ever
|
can you also update the CHANGELOG. |
|
@aitboudad sorry i don't understand, update the CHANGELOG.md for what? |
|
@dosten just add note about the removed deprecations, you can see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/CHANGELOG.md for example |
|
@aitboudad Done! |
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
May 16, 2015
This PR was squashed before being merged into the 3.0-dev branch (closes #14145). Discussion ---------- Removed deprecations in Filesystem component | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 5d1e558 Removed deprecations in Filesystem component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.