-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[console][ArrayInput] avoid return array value for getFirstArgument. #14197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aitboudad
commented
Apr 3, 2015
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Fixed tickets | #14116 |
Tests pass? | yes |
License | MIT |
e95da2f
to
4b006a2
Compare
Can someone explain me why this is the right fix? I mean, why shouldn't it return an array if the first argument is an array? |
@aitboudad Afaics, the first argument is not necessarily the command being executed. For example, the |
So, if the |
@xabbuh yes I know :) in this PR I'm not attempts to return the command name as first argument but just to make ArrayInput compatible with InputInterface. |
I agree with @mpdude, I don't think this is the right fix. |
What about #14205? |
Updated #14205. |
what do you think to change /**
* @return mixed
*/
public function getFirstArgument(); |
Is the first argument guaranteed to be the command name and thus a string? If yes, where can I see that? |
closing in favor of #14205 |