Make getPhpFiles actually behave like PHP $_FILES #14254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot looks like your script moving things automatically messed up. There is an unrelated commit there. |
|
Btw, given that the original PR is described as being incomplete, it would probably be better to let @albe open a PR himself so that it can continue the work in it |
|
Closing this PR. @albe Can you submit a new one on symfony/symfony? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was submitted on the symfony/DomCrawler read-only repository by @albe and moved automatically to the main Symfony repository (closes symfony/dom-crawler#21).
See bug #14021 (#14021).
This is by no means complete, as probably also getPhpValues should be fixed accordingly to "underscore" variable names.