[Form] Cleanup deprecation notices #14258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb4ccfa to
339ed89
Compare
339ed89 to
3f58862
Compare
|
Thanks Nicolas! |
webmozart
added a commit
that referenced
this pull request
Apr 8, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Cleanup deprecation notices | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This uses the same technique used for FlattenException in HttpKernel that prevents repeated notices triggered by the constructor. Commits ------- 3f58862 [Form] Cleanup deprecation notices
|
@nicolas-grekas this does not work in case the new ChoiceView was used before your usage of the old ChoiceView. you won't get any warning in this case as the class is already loaded |
|
If you extend from the deprecated ChoiceView, DebugClassLoader will warn you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same technique used for FlattenException in HttpKernel that prevents repeated notices triggered by the constructor.