[Form] Add "range" type #11979 #14289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe ValidatorTypeGuesser should also return this range type when the range contraint is found. |
|
@jaytaph I'm not sure, this would certainly be a BC breaker... |
228a80d to
fd26a7e
Compare
|
@Kryniol yes, you are right. But it would make more sense to have it guessed to range whenever there is a range constraint.. Maybe this could be postponed to 3.0 (if it's still a good idea) |
|
I think it's really nice feature for 3.0. I could take care of that after this PR is done, for now I'm struggling with Travis. |
a8ff493 to
f03948a
Compare
[Form] Add range type symfony#11979 - registered RangeType in CoreExtension [Form] Add range type symfony#11979 - added tests for rendering the form field and validating options [Form] Add range type symfony#11979 - added copyright lines in RangeTypeTest class [Form] Add range type symfony#11979 - minor formatting fixes, added author block
f03948a to
dd08aeb
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken over #12693, added tests for rendering and building the form field and fixed some parts. The linked PR could be probably closed if this one is OK. This is my first PR to the Symfony2 repo so please let me know if anything is missing.