Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[EventDispatcher] Added the sorted priority information on phpdoc of the getListeners method #14304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dupuchba
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT

Added the sorting by descending priority information on the EventDisparcherInterface

@xabbuh
Copy link
Member

xabbuh commented Apr 13, 2015

I don't feel that this information should be added to the interface, but to the actual implementation in the EventDispatcher class instead. Adding this information to the interface adds a new requirement to fullfil for third-party implementation of the interface which should be considered a BC break.

@dupuchba
Copy link
Contributor Author

Ok @xabbuh I didn't thought about that :-).
Let me add The information to the EventDispatcher instead.

@dupuchba dupuchba force-pushed the add-better-phpdoc-message-on-eventdispatcherinterface branch from 0af321c to 9646f4a Compare April 13, 2015 10:37
@dupuchba
Copy link
Contributor Author

@xabbuh done, tell me if you have other observations :-).

@stof
Copy link
Member

stof commented Apr 13, 2015

@xabbuh this is already a requirement today actually. The code already relies on listeners being sorted (the TraceableeventDispatcher would dispatch in the wrong order in case the inner dispatcher does not return them sorted for instance). So it is already a requirement of the interface

@dupuchba
Copy link
Contributor Author

@stof ok, I was not sure about it so It has to go on the interface.

@dupuchba dupuchba force-pushed the add-better-phpdoc-message-on-eventdispatcherinterface branch from 9646f4a to c3eecb5 Compare April 13, 2015 10:57
@dupuchba
Copy link
Contributor Author

@stof @xabbuh done

@xabbuh
Copy link
Member

xabbuh commented Apr 13, 2015

@stof Then it must indeed be added to the interface itself.

Sorry for the confusion @dupuchba.

@dupuchba
Copy link
Contributor Author

@xabbuh no problem, your feedback was still valuable.

@dupuchba
Copy link
Contributor Author

@xabbuh is it ok to merge ?(ping @stof )

@jakzal
Copy link
Contributor

jakzal commented Apr 20, 2015

👍

@fabpot
Copy link
Member

fabpot commented Apr 20, 2015

Thank you @dupuchba.

@fabpot fabpot merged commit c3eecb5 into symfony:2.3 Apr 20, 2015
fabpot added a commit that referenced this pull request Apr 20, 2015
…on phpdoc of the getListeners method (dupuchba)

This PR was merged into the 2.3 branch.

Discussion
----------

[EventDispatcher] Added the sorted priority information on phpdoc of the getListeners method

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT

Added the sorting by descending priority information on the `EventDisparcherInterface`

Commits
-------

c3eecb5 Add better phpdoc message for getListeners method of the EventDispatcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants