-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[EventDispatcher] Added the sorted priority information on phpdoc of the getListeners method #14304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventDispatcher] Added the sorted priority information on phpdoc of the getListeners method #14304
Conversation
I don't feel that this information should be added to the interface, but to the actual implementation in the |
Ok @xabbuh I didn't thought about that :-). |
0af321c
to
9646f4a
Compare
@xabbuh done, tell me if you have other observations :-). |
@xabbuh this is already a requirement today actually. The code already relies on listeners being sorted (the TraceableeventDispatcher would dispatch in the wrong order in case the inner dispatcher does not return them sorted for instance). So it is already a requirement of the interface |
@stof ok, I was not sure about it so It has to go on the interface. |
9646f4a
to
c3eecb5
Compare
@xabbuh no problem, your feedback was still valuable. |
👍 |
Thank you @dupuchba. |
…on phpdoc of the getListeners method (dupuchba) This PR was merged into the 2.3 branch. Discussion ---------- [EventDispatcher] Added the sorted priority information on phpdoc of the getListeners method | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT Added the sorting by descending priority information on the `EventDisparcherInterface` Commits ------- c3eecb5 Add better phpdoc message for getListeners method of the EventDispatcher
Added the sorting by descending priority information on the
EventDisparcherInterface