[Translation] added an --all option to the debug:translation command #14237 #14320

sgehrig · 2015-04-11T16:58:53Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#14237
License	MIT
Doc PR	-

submit changes to the documentation

This PR adds an --all option the debug:translation command to enable debugging translations in all registered bundles AND the app directory.

aitboudad · 2015-04-11T17:15:33Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

-        $loader = $this->getContainer()->get('translation.loader');
-        $kernel = $this->getContainer()->get('kernel');
+        /** @var TranslationLoader $loader */
+        $loader = $this->getContainer()


Why add line break here ? we can do $loader = $this->getContainer()->get('translation.loader');

aitboudad · 2015-04-11T17:34:53Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

                }
            }
+        } elseif ($input->getArgument('all')) {


it should be $input->getOption('all')

aitboudad · 2015-04-11T17:45:00Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

-                new InputOption('only-missing', null, InputOption::VALUE_NONE, 'Displays only missing messages'),
-                new InputOption('only-unused', null, InputOption::VALUE_NONE, 'Displays only unused messages'),
-            ))
+            ->setAliases(


->setAliases(array(

aitboudad · 2015-04-11T17:49:18Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

+    private function loadFallbackCatalogues($locale, $translationsPath, TranslationLoader $loader)
+    {
+        $fallbackCatalogues = array();
+        $translator         = $this->getContainer()->get('translator');


remove extra spaces $translator =

aitboudad · 2015-04-11T17:50:18Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

@@ -40,14 +42,19 @@ protected function configure()
        $this
            ->setName('debug:translation')
            ->setAliases(array(
-                'translation:debug',
+                    'translation:debug',


remove indent

xabbuh · 2015-04-12T07:53:54Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

-        }
-        $table->setHeaders($headers);
+            /** @var \Symfony\Component\Console\Helper\Table $table */
+            $table = new Table($output);


You need to fall back to TableHelper when the Console component is previous to 2.4.

That hasn't changed from the previous implementation. I'm not fully aware of release processes and required BC compatibility in Symphony, but as this is a 2.7 (or rather 2.8 - see @fabpot's comment below) feature, I don't think a compatibility with Console 2.4 is relevant here.
@aitboudad?

@sgehrig use $table = $this->getHelperSet()->get('table'); instead :)

@sgehrig I mean use $table = new Table($output);

see #14338 for the table helper fix

fabpot · 2015-04-12T09:16:38Z

If merged, should be in 2.8.

aitboudad · 2015-04-12T11:51:13Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

+    /**
+     * @param string $locale
+     * @param string $rootPath
+     * @return MessageCatalogue


white-line before return (you can use php-cs-fixer)

aitboudad · 2015-04-12T13:36:03Z

👍

sgehrig · 2015-04-15T07:21:37Z

@aitboudad: Anything more I need to do?

aitboudad · 2015-04-15T09:26:17Z

@sgehrig only one ;) , use $table = new Table($output); instead of getHelperSet

sgehrig · 2015-04-15T20:00:48Z

@aitboudad Done. Thanks for your patience ;-)

aitboudad · 2015-04-24T08:08:44Z

@symfony/deciders Is it ok for you?

aitboudad · 2015-04-28T14:23:20Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

-            $table->render($output);
-        }
+        $output->writeln('');
+        $output->writeln('<info>Legend:</info>');


the legend has been removed see #14473

xabbuh · 2015-04-28T18:57:38Z

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

 use Symfony\Component\Console\Helper\Table;
+use Symfony\Component\HttpKernel\Kernel;
+use Symfony\Component\Translation\Catalogue\MergeOperation;


Imho it would be better to add them in alphabetical order.

sgehrig · 2015-04-28T19:16:06Z

Fixed those coding style issues. They resulted from the rebase merge.

xabbuh · 2015-04-28T19:31:53Z

@sgehrig Thanks, can you please also revert the changes to the other if statements where you wrapped conditions?

sgehrig · 2015-04-28T19:39:18Z

Need to get used to the Symfony code guidelines... ;-) Unnecessary changes should have been reverted...

xabbuh · 2015-04-28T19:45:46Z

👍

@sgehrig I didn't want to bother you. It's just easier to track changes in the future (for example when using git blame) if we limit changes to what is really necessary. Thank you for your patience!

sgehrig · 2015-04-28T19:50:43Z

@xabbuh No problem... ;-)

aitboudad · 2015-04-29T17:36:27Z

Thank you @sgehrig.

…lation command #14237 (sgehrig) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #14320). Discussion ---------- [Translation] added an --all option to the debug:translation command #14237 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14237 | License | MIT | Doc PR | - - [ ] submit changes to the documentation This PR adds an `--all` option the `debug:translation` command to enable debugging translations in all registered bundles *AND* the app directory. Commits ------- 0e7fe79 added the --all option to the debug:translation command

aitboudad added the Translation label Apr 11, 2015

aitboudad reviewed Apr 11, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch 3 times, most recently from b388239 to 38cb884 Compare April 11, 2015 17:25

aitboudad reviewed Apr 11, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch from 38cb884 to 03e40dd Compare April 11, 2015 17:36

aitboudad reviewed Apr 11, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch from 03e40dd to c9deb8c Compare April 11, 2015 17:48

aitboudad reviewed Apr 11, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch from c9deb8c to 38b29fd Compare April 11, 2015 17:49

aitboudad reviewed Apr 11, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch 2 times, most recently from 664d1ab to 9ae342d Compare April 11, 2015 17:53

xabbuh reviewed Apr 12, 2015
View reviewed changes

aitboudad reviewed Apr 12, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch from 9ae342d to 7255e98 Compare April 12, 2015 11:58

sgehrig force-pushed the ticket_14237 branch from 7255e98 to 867727a Compare April 12, 2015 17:34

sgehrig force-pushed the ticket_14237 branch from 867727a to bfcd762 Compare April 15, 2015 20:00

sgehrig force-pushed the ticket_14237 branch from bfcd762 to 8f8f1e6 Compare April 28, 2015 11:29

aitboudad reviewed Apr 28, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch from 8f8f1e6 to 055dcea Compare April 28, 2015 14:29

xabbuh reviewed Apr 28, 2015
View reviewed changes

sgehrig force-pushed the ticket_14237 branch from 055dcea to 6d805b9 Compare April 28, 2015 19:14

added the --all option to the debug:translation command

a737a21

sgehrig force-pushed the ticket_14237 branch from 6d805b9 to a737a21 Compare April 28, 2015 19:38

aitboudad closed this Apr 29, 2015

sgehrig deleted the ticket_14237 branch May 6, 2015 06:46

fabpot mentioned this pull request Nov 16, 2015

Release v2.8.0-BETA1 #16550

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Translation] added an --all option to the debug:translation command #14237 #14320

[Translation] added an --all option to the debug:translation command #14237 #14320

sgehrig commented Apr 11, 2015

aitboudad Apr 11, 2015

aitboudad Apr 11, 2015

aitboudad Apr 11, 2015

aitboudad Apr 11, 2015

aitboudad Apr 11, 2015

xabbuh Apr 12, 2015

sgehrig Apr 12, 2015

aitboudad Apr 12, 2015

aitboudad Apr 12, 2015

xabbuh Apr 13, 2015

fabpot commented Apr 12, 2015

aitboudad Apr 12, 2015

aitboudad commented Apr 12, 2015

sgehrig commented Apr 15, 2015

aitboudad commented Apr 15, 2015

sgehrig commented Apr 15, 2015

aitboudad commented Apr 24, 2015

aitboudad Apr 28, 2015

sgehrig Apr 28, 2015

xabbuh Apr 28, 2015

sgehrig commented Apr 28, 2015

xabbuh commented Apr 28, 2015

sgehrig commented Apr 28, 2015

xabbuh commented Apr 28, 2015

sgehrig commented Apr 28, 2015

aitboudad commented Apr 29, 2015

[Translation] added an --all option to the debug:translation command #14237 #14320

[Translation] added an --all option to the debug:translation command #14237 #14320

Conversation

sgehrig commented Apr 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot commented Apr 12, 2015

Choose a reason for hiding this comment

aitboudad commented Apr 12, 2015

sgehrig commented Apr 15, 2015

aitboudad commented Apr 15, 2015

sgehrig commented Apr 15, 2015

aitboudad commented Apr 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sgehrig commented Apr 28, 2015

xabbuh commented Apr 28, 2015

sgehrig commented Apr 28, 2015

xabbuh commented Apr 28, 2015

sgehrig commented Apr 28, 2015

aitboudad commented Apr 29, 2015