[FrameworkBundle] improve usage of Table helper #14338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `Table` helper if present in favor of the deprecated `TableHelper` class.
1 task
|
@xabbuh |
|
@aitboudad It's deprecated, so imho it should be removed. |
|
@xabbuh deprecated only if it's an instance of TableHelper |
|
@aitboudad That additional check was added to tackle the default helper set, but not breaking it for people using the helper set in another context IIRC. |
|
@xabbuh ok, thank you :) |
|
@aitboudad |
|
@stof this makes sense, thanks ! |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Apr 15, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [FrameworkBundle] improve usage of Table helper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Use the `Table` helper if present in favor of the deprecated `TableHelper` class. Commits ------- 71d84e6 [FrameworkBundle] improve usage of Table helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
Tablehelper if present in favor of the deprecatedTableHelperclass.