Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] added FileLoader. #14359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2015
Merged

[Translation] added FileLoader. #14359

merged 1 commit into from
Apr 18, 2015

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

xabbuh
xabbuh reviewed Apr 15, 2015
View reviewed changes
src/Symfony/Component/Translation/Loader/CsvFileLoader.php
@@ -33,16 +31,8 @@ class CsvFileLoader extends ArrayLoader
*
* @api
*/
public function load($resource, $locale, $domain = 'messages')
public function loadResource($resource)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be protected (like the method in the parent class).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@aitboudad aitboudad force-pushed the translation_file_loader branch from 055c537 to bf89872 Compare April 15, 2015 21:35
@aitboudad aitboudad force-pushed the translation_file_loader branch from bf89872 to 3694e5e Compare April 15, 2015 21:38
@stof
Copy link
Member

stof commented Apr 18, 2015

👍

@fabpot
Copy link
Member

fabpot commented Apr 18, 2015

Thank you @aitboudad.

@fabpot fabpot merged commit 3694e5e into symfony:2.8 Apr 18, 2015
fabpot added a commit that referenced this pull request Apr 18, 2015
@fabpot
feature #14359 [Translation] added FileLoader. (aitboudad)
862bdf1 
This PR was merged into the 2.8 branch.

Discussion
----------

[Translation] added FileLoader.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

3694e5e [Translation] added FileLoader.
@aitboudad aitboudad deleted the translation_file_loader branch April 18, 2015 10:26
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aitboudad @stof @fabpot @xabbuh