👍

I like this idea as well, especially as the implementation is so easy now :) Can you try to make the link more prominent? I did not see it at first and had to closely look to find it on the screenshot.

I like this idea too

@fabpot should the 2.8 branch become the default branch of all Symfony repos now that 2.7 is feature-frozen so that people sending PR open them against 2.8 by default ?

@stof I like to way for the stable release to switch the default branch (like for Silex by the way :)).

Here are some quick proposals to make the link stand out (without adding an icon):

Option 1 or 2 would do for me.

@fabpot this would mean that people not being careful will send us all PRs to 2.7, while only bugfixes should go there. It would be better to have them based on the right version IMO (even though we can switch the target with gh, it is better if the Travis builds are running on the right version, and it also means less chance for conflicts when rebasing)

@javiereguiluz I vote for the option 2 (with the button style)

👍 for the second option.

I'd prefer both 1 + 2 = the button with the cross.

I've combined the 1 and 2 options. Here it is in action:

Do we have buttons anywhere else in the panel?

Looks great 👍

@Tobion I'd say that we don't have any button in any other panel. And I agree that we should avoid this inconsistency.

I like option 1 and 2 as well as the combined one.

@Tobion I'd say that we don't have any button in any other panel. And I agree that we should avoid this inconsistency.

We didn't have something that would justify for a button UI element before, did we? So introducing this now doesn't look wrong to me.

Don't care if its a button or a link but IMO it should be next to authenticated: yes as in example 4 as these belong together. Below the other data, it looks misplaced as it does not fit into the "key: value" pair.

IMO nice would be to have option if we detect role ROLE_PREVIOUS_ADMIN or something similar to be able to easily log back as "admin".

👍 awesome, i like the link next to the 'Authenticated'. if the user has the role ROLE_PREVIOUS_ADMIN we could replace the logout button with something like "logout(link) to old_user"

I think the logout button should be next to Authenticated: Yes, and if the user has the role ROLE_PREVIOUS_ADMIN a new button Exit must appear next to Logged in as: foobar

Here a proposal with button next to the Authenticated: Yes:

And an other one with le link aligned with values:

I like @raziel057 proposal. 👍

Nice one @javiereguiluz !

@raziel057 the problem I see with your first proposal is that the button looks like a badge (obviously my own button proposal also suffer this problem, but it's less problematic because it's not displayed next to the badge).

Regarding your second proposal, I like that the link looks like a real link, but most people here don't want the link to stand out that much. Besides, I'm not sure about the result of aligning the link with the values.

I've committed a new proposal where a new Actions section is created in the security panel:

Considering that in #14458 we might add a new feature to switch the user, this Actions section could hold that button too:

👍 great job :-)

👍 great!
I think that the Switch user button should be renamed to something like Exit when the token has the ROLE_PREVIOUS_ADMIN role.

@javiereguiluz how can i select the user to impersonate?

btw, i like the buttons 👍

@javiereguiluz Can you finish this one? I'd like to merge it ASAP.

I've finished and rebased this PR. Thanks to the new toolbar style, there is no need to discuss about displaying this feature as a link or as a button. It "must" be a link to match the new style:

👍

Thank you @javiereguiluz.