Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue4067 class triggers #14406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2015
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is #14201 rebased on latest 2.7.

This PR moves the deprecation notice triggers introduced in #14050 to file level, as suggested by @stof.

@nicolas-grekas nicolas-grekas force-pushed the issue4067-class-triggers branch from d83acb5 to a3917fc Compare April 19, 2015 10:11
@nicolas-grekas
Copy link
Member Author

We don't trigger deprecation notices on interface, thus I removed https://github.com/symfony/symfony/pull/14201/files#diff-3

@fabpot
Copy link
Member

fabpot commented Apr 19, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit a3917fc into symfony:2.7 Apr 19, 2015
fabpot added a commit that referenced this pull request Apr 19, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

Issue4067 class triggers

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is #14201 rebased on latest 2.7.

This PR moves the deprecation notice triggers introduced in #14050 to file level, as [suggested](#14050 (comment)) by @stof.

Commits
-------

a3917fc [Form] Removed remaining deprecation notices in the test suite
8f297c1 [Form] Moved deprecation notice triggers to file level
@nicolas-grekas nicolas-grekas deleted the issue4067-class-triggers branch April 19, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants