inject asset packages in assets helper service #14419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 20, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #14368 |
| License | MIT |
| Doc PR |
| @@ -558,6 +558,10 @@ private function registerTemplatingConfiguration(array $config, $ide, ContainerB | |||
| 'Symfony\\Bundle\\FrameworkBundle\\Templating\\Loader\\FilesystemLoader', | |||
| )); | |||
| } | |||
|
|
|||
| if ($container->hasDefinition('assets.packages')) { | |||
| $container->getDefinition('templating.helper.assets')->replaceArgument(0, new Reference('assets.packages')); | |||
There was a problem hiding this comment.
the helper service should be removed otherwise
There was a problem hiding this comment.
Though I didn't find circumstances where this ever will happen. If anyone can think of it, we could add a test covering it.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Apr 21, 2015
This PR was merged into the 2.7 branch. Discussion ---------- inject asset packages in assets helper service | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14368 | License | MIT | Doc PR | Commits ------- 6928507 inject asset packages in assets helper service
fabpot
added a commit
that referenced
this pull request
May 7, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [FrameworkBundle] Fix assets test | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT I'm not sure about this change, but the tests introduced in #14419 are failing in master, the same error ocurrs in both tests: `Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The service definition "templating.helper.assets" does not exist.` Commits ------- 92e8799 Fixed test and fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.