[FrameworkBundle] Fix assets test #14564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes the failing tests, the fail in 5.5.9 is because a volatile test (see #14444) and the fails in 5.5.9 (low deps) seems to not be related. |
|
#14419 was on 2.7, do we just have the problem on master? |
|
@fabpot yes, in 2.7 runs ok but it's failing in master |
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
May 7, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [FrameworkBundle] Fix assets test | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT I'm not sure about this change, but the tests introduced in #14419 are failing in master, the same error ocurrs in both tests: `Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The service definition "templating.helper.assets" does not exist.` Commits ------- 92e8799 Fixed test and fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this change, but the tests introduced in #14419 are failing in master, the same error ocurrs in both tests:
Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The service definition "templating.helper.assets" does not exist.