[TwigBundle] Reconfigure twig paths when they are updated #14781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure, but does |
|
I think so, but don't know which version to put there |
|
I'd go for ~2.8, which is the first version that will contain the new resource. |
| */ | ||
| public function __toString() | ||
| { | ||
| return (string) $this->resource; |
There was a problem hiding this comment.
You can do the string casting in the constructor already.
|
👍 |
|
Any other suggestion / improvement ? |
| @@ -74,23 +75,30 @@ public function load(array $configs, ContainerBuilder $container) | |||
| } else { | |||
| $twigFilesystemLoaderDefinition->addMethodCall('addPath', array($path, $namespace)); | |||
| } | |||
| $container->addResource(new FileExistenceResource($path)); | |||
There was a problem hiding this comment.
not needed here as we don't change the container configuration based on the existence of this folder
There was a problem hiding this comment.
Thanks for the hint
https://github.com/symfony/symfony/pull/14781/files#r31505368 not needed here as we don't change the container configuration based on the existence of this folder
|
👍 |
|
Thank you @chbruyand. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh twig paths upon creation and deletion. As we don't care neither about path's modification time nor path's content, a new Resource has been added in the Config Component.
Full discussion in #14778.