[Security][bugfix] "Remember me" cookie cleared on logout with custom "secure"/"httponly" config options [1] #14842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut() It does work for default values of "secure" and "httponly" options, but it would break if one customized those options. symfony#14822
…y" options * test now always pass those options, as they are required * could be considered BC, but RememberMeFactory passes them, so they should've always been treated as required * symfony#14822
…elCookie() uses "secure" and "httponly" options)
| $this->options['domain'], | ||
| $this->options['secure'], | ||
| $this->options['httponly'] | ||
| )); |
There was a problem hiding this comment.
Why? It would make a really long line (difficult to read). 207 chars, which is a "warning sign" under PSR-2, which recommends to split such lines.
There was a problem hiding this comment.
BTW, is it possible to "restart" fabbot.io?
There was a problem hiding this comment.
Why? It would make a really long line (difficult to read). 207 chars, which is a "warning sign" under PSR-2, which recommends to split such lines.
We've got wide monitors and don't mind long lines ;)
but seriously, readability is a personal preference in this case and we tend NOT to brake lines in such cases in the rest of codebase.
BTW, is it possible to "restart" fabbot.io?
Not as far as I know.
|
Thank you @MacDada. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2015
…with custom "secure"/"httponly" config options [1] (MacDada) This PR was squashed before being merged into the 2.3 branch (closes #14842). Discussion ---------- [Security][bugfix] "Remember me" cookie cleared on logout with custom "secure"/"httponly" config options [1] | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14822 | License | MIT | Doc PR | ~ * test now always pass "secure" and "httponly" options, as they are required * could be considered BC, but [`RememberMeFactory` passes them](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php#L21), so they should've always been treated as required * I can squash the commits before merging * Alternative solution: #14843 Commits ------- 18b1c6a [Security][bugfix] "Remember me" cookie cleared on logout with custom "secure"/"httponly" config options [1]
This was referenced Oct 27, 2015
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RememberMeFactorypasses them, so they should've always been treated as required