Removed deprecated stuff from the Config component #14927
Conversation
dosten
commented
Jun 9, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| // as some some loaders do not call the parent __construct() | ||
| // @deprecated should be removed in 3.0 | ||
| $locator = $loader->getLocator() ?: $this->locator; | ||
| $locator = $loader->getLocator(); | ||
| $resource = $locator->locate($resource, $this->currentDir, false); |
There was a problem hiding this comment.
Doesn't that introduce a possible failure? As apparently not all $loader->getLocator() returned something (otherwise the fallback would have never been called), this may now fail as $locator can be empty?
Or was this changed in $loader->getLocator(), so that it always returns a locator?
There was a problem hiding this comment.
well, not calling the parent constructor to initialize the locator in classes extending FileLoader is not supported anymore in 3.0. the object should be built in a working state.
Btw, it looks like we are missing a deprecation warning here to warn about that in 2.x versions. This should be added before removing deprecated stuff from 3.0
There was a problem hiding this comment.
In which branch the deprecation warning should be added? 2.8?
|
This PR is ready to be merged. |
|
👍 |
|
Thank you @dosten. |
…sten) This PR was merged into the 3.0-dev branch. Discussion ---------- Removed deprecated stuff from the Config component | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 07a1790 Removed deprecated stuff from the Config component