[FrameworkBundle] Configurable Serializer name converter #14987
Conversation
dunglas
commented
Jun 15, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | symfony/symfony-docs#5483 |
- Add tests
|
ping @symfony/deciders |
| @@ -970,6 +970,12 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder | |||
| 1, new Reference($config['cache']) | |||
| ); | |||
| } | |||
|
|
|||
| if (isset($config['name_converter']) && $config['name_converter']) { | |||
There was a problem hiding this comment.
IIRC, the isset part is not needed.
|
Can you also create the PR for the docs? |
|
Don't you have to set the default value of the |
|
No. If you do that everything will be converted by default and this is not intended nor a best practice. The name converter definition is here just for convenience and will be removed during the container compilation when not used. |
0c52409 to
e500a71
Compare
|
Code updated and doc added (symfony/symfony-docs#5483) |
Thanks for explaining your intentions. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @dunglas. |
…er (dunglas) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Configurable Serializer name converter | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#5483 - [x] Add tests Commits ------- e500a71 [FrameworkBundle] Configurable Serializer name converter
This PR was squashed before being merged into the 2.8 branch (closes #5483). Discussion ---------- [FrameworkBundle] Name converter of Serializer | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes symfony/symfony#14987 | Applies to | 2.8 | Fixed tickets | n/a Commits ------- 7a4d9fc [FrameworkBundle] Name converter of Serializer