[Profiler][Translation] added filter. #14993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Jun 15, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | ~ |
| Tests pass? | yes |
| License | MIT |
| @@ -57,6 +57,14 @@ | |||
| {% endblock %} | |||
|
|
|||
| {% block panelContent %} | |||
| {% set value = request.query.get('message-type', '-1') %} | |||
There was a problem hiding this comment.
a better name would be filter or type_filter rather than value
There was a problem hiding this comment.
btw, it is not really a message-type filter. It is a state filter
There was a problem hiding this comment.
fixed and thanks for your feedback :)
8583da5 to
65f9291
Compare
|
👍 |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Profiler][Translation] added filter. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT  Commits ------- 65f9291 [Profiler][Translation] added filter.
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.