[2.3] Static Code Analysis for Components #15051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic methods validity: resolved possible fatals random api migration: used mt_* in some of components *printf issues resolved
| $protocol = ''; | ||
| try { | ||
| $protocol = $this->server->get('SERVER_PROTOCOL'); | ||
| } catch (\InvalidArgumentException $mallformedPath) { |
There was a problem hiding this comment.
We merged a PR where all caught exceptions were renamed to $e. So should be this one.
There was a problem hiding this comment.
Emm, why? Code shall be self-explaining.
I could then rename $protocol to $p - it's clear from context what happens...
There was a problem hiding this comment.
I see, ths for the link.
|
👍 |
|
Thank you @kalessil. |
fabpot
added a commit
that referenced
this pull request
Jun 21, 2015
This PR was squashed before being merged into the 2.3 branch (closes #15051). Discussion ---------- [2.3] Static Code Analysis for Components | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Static Code Analysis with Php Inspections (EA Extended): - magic methods validity: resolved possible fatals - random api migration: used mt_* in some of components - *printf issues resolved Commits ------- aa5e616 [2.3] Static Code Analysis for Components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static Code Analysis with Php Inspections (EA Extended):
- magic methods validity: resolved possible fatals
- random api migration: used mt_* in some of components
- *printf issues resolved