Fix choice translation domain for expanded choice widget #15142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good solution. A test would be good though. |
04d1b02 to
12af58d
Compare
12af58d to
52755ba
Compare
|
Added some tests. |
|
👍 2.7 is the correct branch since that is where choice_translation_domain was introduced. |
|
Thank you @jvasseur. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2015
…jvasseur) This PR was merged into the 2.7 branch. Discussion ---------- Fix choice translation domain for expanded choice widget | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15140 | License | MIT This fix the form component using the translation_domain instead of the choice_translation_domain for expanded choice widgets. I had to add the possibility to skip label translation when using ```translation_domain => false``` to do this fix so this can be considered a new feature to. Commits ------- 52755ba Fix choice translation domain for expanded choice widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the form component using the translation_domain instead of the choice_translation_domain for expanded choice widgets.
I had to add the possibility to skip label translation when using
translation_domain => falseto do this fix so this can be considered a new feature to.