Towards 100% HHVM compat #15146
Towards 100% HHVM compat #15146
Conversation
fde6a8c to
ef18372
Compare
| if (false === setlocale(LC_ALL, $required_locales)) { | ||
| $this->markTestSkipped('Could not set any of required locales: '.implode(', ', $required_locales)); | ||
| try { | ||
| $required_locales = array('fr_FR.UTF-8', 'fr_FR.UTF8', 'fr_FR.utf-8', 'fr_FR.utf8', 'French_France.1252'); |
There was a problem hiding this comment.
this should also be changed to camelCase
ef18372 to
900fa14
Compare
|
Regarding the phar error in the DI tests, I suggest to check whether the phar is a compressed one. HHVM does not support compressed phars: facebook/hhvm#4263 |
|
And the HttpKernel tests are passing, but they are polluting the output |
03f4403 to
4a5bd64
Compare
|
Phar fixed, DI component is OK now |
|
@nicolas-grekas I suggest adding a checklist in the PR description with all components which are failing in the 2.3 branch currently, and then checking them when fixed. This would make it easier to follow the PR progress |
7858fa7 to
a2d7b8f
Compare
a2d7b8f to
b9a76ba
Compare
|
|
|
Thank you @nicolas-grekas. |
This PR was merged into the 2.3 branch. Discussion ---------- Towards 100% HHVM compat | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Failing components: - [x] Debug - [x] DependencyInjection - [x] Filesystem - [x] Form - [x] HttpFoundation - [x] Process - [x] Routing Related HHVM issues: - facebook/hhvm#5562 - facebook/hhvm#5561 - facebook/hhvm#5330 - facebook/hhvm#3558 - facebook/hhvm#4901 Commits ------- b9a76ba Towards 100% HHVM compat
| @@ -229,7 +229,7 @@ public function chgrp($files, $group, $recursive = false) | |||
| $this->chgrp(new \FilesystemIterator($file), $group, true); | |||
| } | |||
| if (is_link($file) && function_exists('lchgrp')) { | |||
| if (true !== @lchgrp($file, $group)) { | |||
| if (true !== @lchgrp($file, $group) || (defined('HHVM_VERSION') && !posix_getgrnam($group))) { | |||
There was a problem hiding this comment.
are posix functions always available on HHVM ?
|
Great job! I think |
|
@soullivaneuh see #15164 |
|
Indeed, thanks! 👍 Sullivan SENECHAL
|
Failing components:
Related HHVM issues: