[Asset] Allow object implementing __toString() being passed to packages #15158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 this is usually the wrong solution. All these parameters are supposed to be a string, and not an object. So the calling code must be fixed and not the library. |
|
LiipImagineBundle is returning a Twig_Markup from a Twig filter. I guess this is to avoid auto-escaping. But there is a much more sensible way to do it, which will not suffer from this issue: marking the filter as returning safe content. And btw, I don't see any reason why LiipImagineBundle does that. The string they return is not escaped AFAICT. In any case, this should be fixed in LiipImagineBundle instead |
fabpot
added a commit
that referenced
this pull request
May 6, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [TwigBridge] Add form templates for Bootstrap 5 | Q | A | ------------- | --- | Branch | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | [#15158](symfony/symfony-docs#15158) This PR add support for [Bootstrap 5](https://v5.getbootstrap.com/) * Removal of the `form-group` class as it no longer exists in Bootstrap 5. Instead, row `div` have a `mb-3` class by default that can be override with the `row_attr` option. * Errors are no longer display inside `label` but after the `widget` (or `help` if present). * Replace `form-control` with `form-select` in `choice_widget_collapsed` block. * Replace `form-control` with `form-range` in `form_widget_simple` block when the type is `range`. * Add `form-control-color` to the `widget` class if type is `color`. * Replace `small` with `div` element for `help` and also remove the `text-muted` class. * Update the `percent_widget` and `money_widget` to handle correctly prepend and append elements. * Drop support for custom file input as it's no longer (or yet ?) supported in Bootstrap 5 [Bootstrap 5 forms overview](https://v5.getbootstrap.com/docs/5.0/forms/overview/) [Bootstrap 5 migration](https://v5.getbootstrap.com/docs/5.0/migration/) Here is the result:   Commits ------- d52d096 [TwigBridge] Add form templates for Bootstrap 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
LiipImagineBundlewould return aTwig_Markupinstance and one passes that to theassets()helper.