Codestin Search App

jamyouss · 2015-07-04T19:50:39Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Add the possibility to have custom message for unique entity constraint.
For example if we have a collection of entities in a form, the message can be more expressive.

Example:

/**
 * Town
 *
 * @ORM\Entity()
 * @UniqueEntity(fields={"city"}, message="The city '{{ city }}' is already used.")
 */
class Town
{

I accidentally closed the previous opened PR (#13787), that why a recreate a pull request.

Minishlink · 2015-07-04T20:19:35Z

Thanks 👍

linaori · 2015-07-04T21:32:40Z

Is the twig style standard or the translations style standard? {{ var }} vs %var%.

Minishlink · 2015-07-04T21:42:56Z

According to other uses of variables in constraints messages (eg. EmailValidator), the standard is twig-style.

oleg-andreyev · 2015-07-06T10:52:12Z

All violations messages are passed to translator (e.g.: \Symfony\Component\Validator\Context\ExecutionContext::addViolation) where placeholders are replaced (see \Symfony\Component\Translation\Translator::trans), so your value must be added to $parameters and let translator do it's job.

For example see: EmailValidator

keradus · 2015-07-06T15:42:35Z

no new tests needed for that new behavior ?

OskarStark · 2015-07-07T08:53:15Z

great work! 👍

jamyouss · 2015-07-07T10:15:31Z

@keradus I don't think so because i don't change the validation behaviour.

keradus · 2015-07-07T15:30:16Z

OK, but how do we know that new behaviour works after some time? Tests can prove that when sb refactor sth this behaviour will still be working ;)

SofHad · 2015-07-07T16:07:17Z

Good 👍

jamyouss · 2015-07-07T20:36:55Z

@keradus you're right, i gonna add some tests

OskarStark · 2015-07-20T20:57:48Z

thank you @Razmo ,give me a ping an i'll review it

jamyouss · 2015-07-21T07:09:37Z

You're welcome @OskarStark !
What does "give me a ping" mean ? (I'm not used to contribute to projects on github)

OskarStark · 2015-07-21T07:49:37Z

if you use @OskarStark i get a direct notification via mail, as you did ;-)

EDIT: Sorry @Razmo , didn't see, that you already added the test.
Can you please extend the test to check a unique constraint over 2 fields?

jamyouss · 2015-07-23T21:14:37Z

@OskarStark test updated

OskarStark · 2015-07-24T08:08:41Z

hmm, I don't know why the travis build is broken with 5.6, can you have a look @Razmo

jamyouss · 2015-07-24T10:27:07Z

@OskarStark I run phpunit test in local and i have 5 failure on Symfony\Component\HttpKernel\Tests\HttpCache\HttpCacheTest and 1 failure on Symfony\Component\Finder\Tests\Iterator\RecursiveDirectoryIteratorTest::testSeek

I don't think that it is caused by my changes

EDIT: weird, it's ok now but i didn't make any changes

OskarStark · 2015-07-24T11:55:41Z

hmm, ok

ping @xabbuh @stof

xabbuh · 2015-10-02T07:50:19Z

You need to make sure that the PropertyAccess component is actually available and you should add it to the suggest section in composer.json.

xabbuh · 2015-10-02T07:54:29Z

Wouldn't it be better to be able to configure a list of object property names whose values would be passed to the actual constraint through the setParameter() method of the constraint violation builder?

jamyouss · 2015-10-05T19:46:40Z

Thank you @stof and @xabbuh for those feedbacks. I'm going to make updates as soon as possible.

…it to suggest section

jamyouss · 2015-10-11T15:10:15Z

@stof @xabbuh : PR updated !
My PR is based on the 2.6 branch. Do i need to merge the 2.7 into my branch ?

jamyouss · 2015-10-23T08:53:11Z

ping @stof

OskarStark · 2015-10-23T09:22:21Z

@Razmo the merge to the 2.7 branch is done automatically afterwards

jamyouss · 2015-10-23T09:57:45Z

@OskarStark Ok thx

jamyouss · 2015-10-23T10:00:29Z

@OskarStark Phpunit tests passed in my local but didn't pass on travis. Have you any idea why ?

OskarStark · 2015-10-23T10:01:32Z

no sorry @Razmo

xabbuh · 2015-10-23T11:34:24Z

Failures seem to be related to the fact that your changes are based off the 2.6 branch.

jamyouss · 2015-10-23T11:57:39Z

Wired because because my branch uniqueEntityCustomMessage is sync with the 2.6 branch

xabbuh · 2015-10-26T10:42:09Z

@Razmo Sure, but Symfony 2.6 itself doesn't receive bug fixes anymore. Probably, you can better reopen the PR based on the 2.8 branch.

jamyouss · 2015-10-26T10:57:52Z

Close this PR and reopen it based on 2.8 branch

Jamal Youssefi and others added 5 commits February 24, 2015 16:14

display custom message for uniqueEntity constraint

c1ea6e4

fix forgot code convention

f5a7ba6

fix code convention

ece9066

Merge branch '2.6' into uniqueEntityCustomMessage

584bdc2

fix code convention

a42fd82

jamyouss added 2 commits July 11, 2015 03:55

Merge branch '2.6' into uniqueEntityCustomMessage

44807c6

add test for uniqueEntity custom message

88c882c

Minishlink mentioned this pull request Jul 19, 2015

Added {{ value }} message placeholder to UniqueEntityValidator #15279

Closed

update tests for uniqueEntity custom message

f5b1115

Merge branch '2.6' into uniqueEntityCustomMessage

abc217b

xabbuh reviewed Oct 2, 2015
View reviewed changes

fabpot added the Form label Oct 5, 2015

jamyouss added 5 commits October 10, 2015 16:42

Merge branch '2.6' into uniqueEntityCustomMessage

d620a66

throw exception if PropertyAccess component is not available and add …

90a6f52

…it to suggest section

fix regex pattern

3ceda08

fix uniqueEntity parameters replacement and tests

b5f239c

apply coding standard patch

1c86b16

jamyouss closed this Oct 26, 2015

jamyouss mentioned this pull request Oct 28, 2015

Unique entity custom message #16345

Closed

Uh oh!

Conversation

jamyouss commented Jul 4, 2015

Uh oh!

Minishlink commented Jul 4, 2015

Uh oh!

linaori commented Jul 4, 2015

Uh oh!

Minishlink commented Jul 4, 2015

Uh oh!

oleg-andreyev commented Jul 6, 2015

Uh oh!

keradus commented Jul 6, 2015

Uh oh!

OskarStark commented Jul 7, 2015

Uh oh!

jamyouss commented Jul 7, 2015

Uh oh!

keradus commented Jul 7, 2015

Uh oh!

SofHad commented Jul 7, 2015

Uh oh!

jamyouss commented Jul 7, 2015

Uh oh!

OskarStark commented Jul 20, 2015

Uh oh!

jamyouss commented Jul 21, 2015

Uh oh!

OskarStark commented Jul 21, 2015

Uh oh!

jamyouss commented Jul 23, 2015

Uh oh!

OskarStark commented Jul 24, 2015

Uh oh!

jamyouss commented Jul 24, 2015

Uh oh!

OskarStark commented Jul 24, 2015

Uh oh!

xabbuh Oct 2, 2015

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Oct 2, 2015

Uh oh!

jamyouss commented Oct 5, 2015

Uh oh!

jamyouss commented Oct 11, 2015

Uh oh!

jamyouss commented Oct 23, 2015

Uh oh!

OskarStark commented Oct 23, 2015

Uh oh!

jamyouss commented Oct 23, 2015

Uh oh!

jamyouss commented Oct 23, 2015

Uh oh!

OskarStark commented Oct 23, 2015

Uh oh!

xabbuh commented Oct 23, 2015

Uh oh!

jamyouss commented Oct 23, 2015

Uh oh!

xabbuh commented Oct 26, 2015

Uh oh!

jamyouss commented Oct 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants