[DependencyInjection] Added ParameterBagInterface::remove #15219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add a |
I guess it's out of this scope |
|
@lyrixx what is the gain ? This sound like a free BC for no gain. |
|
@mickaelandrieu Now, we can be sure the method exist before calling it. |
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Jul 14, 2015
…ove (lyrixx) This PR was merged into the 3.0-dev branch. Discussion ---------- [DependencyInjection] Added ParameterBagInterface::remove | Q | A | ------------- | --- | Bug fix? | kinda | New feature? | no | BC breaks? | only between 2.X and 3.X, this PR target 3.X | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I created this PR because the method is implemented in `ParameterBag` but is not declared in the interface. Commits ------- c13a4ff [DependencyInjection] Added ParameterBagInterface::remove
|
This should be documented in the upgrade file. |
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jul 15, 2015
This commit documents the addition of the `remove()` method to the `ParameterBagInterface` which was done in symfony#15219.
|
see #15286 |
|
@xabbuh 👍 thank you. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2015
…cs (xabbuh) This PR was merged into the 3.0-dev branch. Discussion ---------- [DependencyInjection] mention added method in upgrade docs | Q | A | ------------- | --- | Fixed tickets | #15219 | License | MIT This commit documents the addition of the `remove()` method to the `ParameterBagInterface` which was done in #15219. Commits ------- 706d1a8 mention added method in upgrade docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR because the method is implemented in
ParameterBagbut is not declared in the interface.