[php7] Fix for substr() always returning a string #15386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I don't have the remaining failure on the Yaml component. I believe a php7 bug has been fixed that is currently not deployed on travis. |
| // Convert false values (from a previous call to substr()) to null | ||
| if (false === $value) { | ||
| // Convert empty values to null | ||
| if (!isset($value[0])) { |
There was a problem hiding this comment.
why not using empty instead ?
There was a problem hiding this comment.
$a = '0';
empty($a) === truewhich would be wrong
fabpot
added a commit
that referenced
this pull request
Jul 28, 2015
…-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [php7] Fix for substr() always returning a string | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 | License | MIT | Doc PR | - This should be the last required fix for PHP7 support. The patch in the debug component is a workaround for a bug in PHP7 (http://3v4l.org/8rm9B) that is going to be fixed soon (@jpauli power). Commits ------- 77ee866 [php7] Fix for substr() always returning a string
|
I pushed a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last required fix for PHP7 support.
The patch in the debug component is a workaround for a bug in PHP7 (http://3v4l.org/8rm9B) that is going to be fixed soon (@jpauli power).