[Debug] Remove deprecated ExceptionHandler::createResponse #15422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Aug 1, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
b825c94 to
0254143
Compare
| * `ErrorHandler::handleFatal()` has been removed, use handleFatalError() instead. | ||
| * `ExceptionHandler::createException()` has been removed. | ||
| * `ExceptionHandler::utf8Htmlize()` has been removed. | ||
| * `Exception/DummyException` has been removed. |
There was a problem hiding this comment.
This should be merged in the branch where it was done instead of master.
There was a problem hiding this comment.
this is master, where it has been removed
There was a problem hiding this comment.
I meant that it should be added in the branch where the deprecations were done.
0254143 to
df4e983
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 1, 2015
…onse (nicolas-grekas) This PR was merged into the 3.0-dev branch. Discussion ---------- [Debug] Remove deprecated ExceptionHandler::createResponse | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- df4e983 [Debug] Remove deprecated ExceptionHandler::createResponse
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.