Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UI & CSS improvement to new toolbar #15503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2015
Merged

UI & CSS improvement to new toolbar #15503

merged 2 commits into from
Sep 30, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 10, 2015

  • Created a generic class for right floating toolbar blocks, so it can be reused by other blocks serving the same goal (the Sylius toolbar block for instance)

  • Added a way to group toolbar info pieces, this makes the bigger info blocks easier to read:

    sf-toolbar-group

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@javiereguiluz
Copy link
Member

1) I like the way you grouped contents in the "config" panel. I'd propose to slightly increase the separation of the blocks:

Before

before

After

after

/* Before */
.sf-toolbar-block .sf-toolbar-info-group {
    margin-bottom: 4px;
    padding-bottom: 2px;
}

/* After */
.sf-toolbar-block .sf-toolbar-info-group {
    margin-bottom: 6px;
    padding-bottom: 4px;
}

2) I don't like the new "request" panel. In the previous "config" panel, it's OK to separate contents into groups because they have nothing to do with each other. However, in the "request" panel, things are different but still closely related.

Besides, being such a small block, when you separate into groups and un-align contents, reading flow is worsened. Compare these images:

Before

request_before

After

request_after

And this is the "expected reading flow" of both designs:

read_flow

@stof
Copy link
Member

stof commented Aug 11, 2015

I agree with @javiereguiluz here

@OskarStark
Copy link
Contributor

  1. i think the 2 pixels make it more readable, but ... not so important to me
  2. i agree with @javiereguiluz

@linaori
Copy link
Contributor

linaori commented Aug 11, 2015

I agree with the alignment that @javiereguiluz mentioned, maybe it's my "OCD", but I prefer it aligned as well.

@wouterj
Copy link
Member Author

wouterj commented Aug 23, 2015

I've reverted grouping in the request panel.

Ready to merge @symfony/deciders ?

@Tobion
Copy link
Contributor

Tobion commented Aug 26, 2015

I'm a proponent of semantic css so a class name like sf-toolbar-block-right is wrong to me. And I don't really see the point of exposing a class for a three-liner that any bundle can do itself?

@fabpot
Copy link
Member

fabpot commented Sep 14, 2015

👍

@fabpot
Copy link
Member

fabpot commented Sep 28, 2015

@wouterj Can you rebase so that I can merge this one? Thanks.

@wouterj
Copy link
Member Author

wouterj commented Sep 30, 2015

@fabpot I've rebased it now, sorry for the delay

@fabpot fabpot merged commit 049fdfe into symfony:2.8 Sep 30, 2015
fabpot added a commit that referenced this pull request Sep 30, 2015
This PR was merged into the 2.8 branch.

Discussion
----------

UI & CSS improvement to new toolbar

* Created a generic class for right floating toolbar blocks, so it can be reused by other blocks serving the same goal (the Sylius toolbar block for instance)
* Added a way to group toolbar info pieces, this makes the bigger info blocks easier to read:

  ![sf-toolbar-group](https://cloud.githubusercontent.com/assets/749025/9178378/41987f02-3f97-11e5-971e-37f44a47d56d.png)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

049fdfe Add a way to group toolbar info pieces
23b8a56 Added general sf-toolbar-block-right class
@wouterj wouterj deleted the toolbar branch September 30, 2015 17:32
@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants