-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
UI & CSS improvement to new toolbar #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1) I like the way you grouped contents in the "config" panel. I'd propose to slightly increase the separation of the blocks: Before After /* Before */
.sf-toolbar-block .sf-toolbar-info-group {
margin-bottom: 4px;
padding-bottom: 2px;
}
/* After */
.sf-toolbar-block .sf-toolbar-info-group {
margin-bottom: 6px;
padding-bottom: 4px;
} 2) I don't like the new "request" panel. In the previous "config" panel, it's OK to separate contents into groups because they have nothing to do with each other. However, in the "request" panel, things are different but still closely related. Besides, being such a small block, when you separate into groups and un-align contents, reading flow is worsened. Compare these images: Before After And this is the "expected reading flow" of both designs: |
I agree with @javiereguiluz here |
|
I agree with the alignment that @javiereguiluz mentioned, maybe it's my "OCD", but I prefer it aligned as well. |
I've reverted grouping in the request panel. Ready to merge @symfony/deciders ? |
I'm a proponent of semantic css so a class name like |
👍 |
@wouterj Can you rebase so that I can merge this one? Thanks. |
@fabpot I've rebased it now, sorry for the delay |
This PR was merged into the 2.8 branch. Discussion ---------- UI & CSS improvement to new toolbar * Created a generic class for right floating toolbar blocks, so it can be reused by other blocks serving the same goal (the Sylius toolbar block for instance) * Added a way to group toolbar info pieces, this makes the bigger info blocks easier to read:  | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 049fdfe Add a way to group toolbar info pieces 23b8a56 Added general sf-toolbar-block-right class
Created a generic class for right floating toolbar blocks, so it can be reused by other blocks serving the same goal (the Sylius toolbar block for instance)
Added a way to group toolbar info pieces, this makes the bigger info blocks easier to read: