Unpack nested array instead of using temp var #15506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status: Reviewed |
|
@dosten Did you check if there are other occurrences of this in the code? |
|
@nicolas-grekas Done! but the failing tests in PHP7 seems to be not related. |
|
👍 |
1 similar comment
|
👍 |
|
Thanks for run the test suite again :) |
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
Aug 11, 2015
This PR was squashed before being merged into the 3.0-dev branch (closes #15506). Discussion ---------- Unpack nested array instead of using temp var | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Since php 5.5 we can [unpack nested arrays with `list()`](http://php.net/manual/en/control-structures.foreach.php#control-structures.foreach.list) to avoid temp vars. Commits ------- 20e9ed6 Unpack nested array instead of using temp var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since php 5.5 we can unpack nested arrays with
list()to avoid temp vars.