[Translation] added <tool> element metadata to XliffFileDumper #15551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Aug 14, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15190 |
| License | MIT |
| Doc PR | ~ |
af5cfcf to
9a15228
Compare
| @@ -36,6 +48,10 @@ public function dump(MessageCatalogue $messages, $options = array()) | |||
| $this->defaultLocale = \Locale::getDefault(); | |||
| } | |||
|
|
|||
| if (array_key_exists('tool_info', $options)) { | |||
| $this->toolInfo = array_merge($this->toolInfo, $options['tool_info']); | |||
There was a problem hiding this comment.
this is not a good idea. You should not change the state of the dumper as it will affect subsequent dumps too
There was a problem hiding this comment.
btw, this is precisely the reason why we introduced the new formatCatalogue method to be able to access options while dumping (see the YamlFileDumper)
There was a problem hiding this comment.
fixed and thank you :)
a811026 to
de5fa4e
Compare
| { | ||
| $defaultLocale = \Locale::getDefault(); |
There was a problem hiding this comment.
I would avoid doing that call when the default locale is specified. It will avoid the dependency on Intl (or the stub) when you specify the default locale explicitly). The old code was supporting this
de5fa4e to
70eac8c
Compare
70eac8c to
135233e
Compare
|
ping @symfony/deciders |
135233e to
f667a34
Compare
|
👍 |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Sep 1, 2015
…leDumper (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [Translation] added <tool> element metadata to XliffFileDumper | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15190 | License | MIT | Doc PR | ~ Commits ------- f667a34 [Translation] added <tool> element metadata to XliffFileDumper
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.