Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix BC break after split of ACL from core #15592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 23, 2015

Rebased version of #15520

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@xabbuh
Copy link
Member

xabbuh commented Aug 25, 2015

Do we still need this (given the changes done in 1270e72)?

@wouterj
Copy link
Member Author

wouterj commented Aug 25, 2015

@xabbuh yes, when installing symfony/symfony, only the root composer.json is what matters and it does not require the not included Security ACL package.

@xabbuh
Copy link
Member

xabbuh commented Aug 25, 2015

indeed 👍

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Aug 26, 2015

Thank you @wouterj.

@fabpot fabpot merged commit 7e9991e into symfony:2.8 Aug 26, 2015
fabpot added a commit that referenced this pull request Aug 26, 2015
This PR was merged into the 2.8 branch.

Discussion
----------

Fix BC break after split of ACL from core

Rebased version of #15520

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7e9991e Fix BC break after split of ACL from core
@wouterj wouterj deleted the patch-15 branch August 26, 2015 08:51
@wouterj
Copy link
Member Author

wouterj commented Aug 26, 2015

Would there be a way to warn package maintainers that they have to add symfony/security-acl to the requirements in order to have 3.0 support?

@dosten
Copy link
Contributor

dosten commented Aug 26, 2015

@wouterj maybe we can add symfony/security-acl as a suggested package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants