[Validator] Fixed group sequence using explicit group for cascaded pr… #15659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @webmozart |
|
According to JSR303:
(Also see Example 3.12 under the same section) |
|
Hi @rpg600! :) As you can read in @teohhanhui's quote, this is not a bug but an intended feature. However, you can explicitly pass the GroupSequence to the validator instead of redefining the Default group: $violations = $validator->validate($user, new GroupSequence(['User', 'UserAddress']));This should fix your problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…operties
In a group sequence, all properties (and cascaded ones) hosted on class A and belonging to the Default group implicitly belong to the group A. However even if we explicitly set a group for cascaded properties, the Default group is always propagated making it impossible to validate our cascaded properties.
For explicit groups the Default group must not be propagated.
Here is an example of use case https://gist.github.com/rpg600/abb765ad2d4446d52e0b that will be fixed.