[WebProfilerBundle] deprecated import/export commands #15709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Sep 7, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | part of #11742 |
| License | MIT |
| Doc PR | n/a |
|
Shouldn't the import() and export() methods of the profiler be deprecated as well? https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/HttpKernel/Profiler/Profiler.php#L141 |
|
I agree the import/export can be removed. I never used it myself. And if somebody needs similar functionality, he can implement it himself easily as he has access to all methods needed. |
|
We agreed on deprecated the commands, not the methods, but I think it makes sense. I will do that now. |
|
done |
| @@ -149,6 +151,8 @@ public function export(Profile $profile) | |||
| * @param string $data A data string as exported by the export() method | |||
| * | |||
| * @return Profile A Profile instance | |||
| * | |||
| * @deprecated since Symfony 2.8, to be removed in 3.0. | |||
There was a problem hiding this comment.
deprecation warnings should be triggered
b3f3bf9 to
5772c15
Compare
|
Tests are failing. |
|
👍 for deprecating/removing this. |
5772c15 to
943fec9
Compare
|
tests fixed now |
fabpot
added a commit
that referenced
this pull request
Sep 9, 2015
…(fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] deprecated import/export commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of #11742 | License | MIT | Doc PR | n/a Commits ------- 943fec9 [HtppKernel] deprecated Profiler::import/export 17e00b9 [WebProfilerBundle] deprecated import/export commands
fabpot
added a commit
that referenced
this pull request
Sep 15, 2015
…commands (jakzal) This PR was merged into the 3.0-dev branch. Discussion ---------- [WebProfilerBundle][HttpKernel] removed import/export commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | part of #11742 | License | MIT | Doc PR | n/a Follow up for #15709. Commits ------- c1d028e [HttpKernel] removed Profiler::import/export 1672a83 [WebProfilerBundle] removed import/export commands
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…mmands (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] deprecated import/export commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of symfony#11742 | License | MIT | Doc PR | n/a Commits ------- 943fec9 [HtppKernel] deprecated Profiler::import/export 17e00b9 [WebProfilerBundle] deprecated import/export commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.