[Routing] Revert to rawurlencode + whitelisting of '/' #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Jul 7, 2011
|
After reading 761724a I think we won't be able to satisfy everyone here :) @Seldaek, how about adding configuration option for UrlGenerator::$decodedChars ? That way anyone could easily extend this list for their needs (e.g. I would add commas - see GH-752). ...but maybe it is overkill and extending class and changing class references in config is good enough. |
|
@MHeleniak: Don't worry I didn't forget about your issue :) I tested it here, matching on commas is still working, even when it's urlencoded. Please check it works for you though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more discussion on 761724a - sorry you merged too fast for once ;)