[Validator] mark test as legacy #15767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @TomasVotruba. |
fabpot
added a commit
that referenced
this pull request
Sep 12, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Validator] mark test as legacy | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ref #15708 (comment) Failing test are hhvm binaries: https://travis-ci.org/symfony/symfony/jobs/79951993#L530 Commits ------- cf18a99 [Validator] mark test as legacy
|
Thanks |
|
The deprecation warning in the constructor is still missing when passing a legacy validator (which is why the tests were passing without the legacy group btw) |
|
Could you link me there pls? |
|
@TomasVotruba in the constructor of the ValidationExtension (the BC layer being covered by the test you marked as legacy) |
|
see #16101 for the missing deprecation triggers |
fabpot
added a commit
that referenced
this pull request
Oct 4, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Form] add missing deprecation triggers | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #15767 | License | MIT | Doc PR | Passing implementations of the pre 2.5 validator API to the constructors of the `ValidatorExtension` and the `ValidationListener` must trigger a deprecation. Commits ------- bcd3946 [Form] add missing deprecation triggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #15708 (comment)
Failing test are hhvm binaries: https://travis-ci.org/symfony/symfony/jobs/79951993#L530