Convert Output::write's type to an options arg where verbosity can be passed in as well #15772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Seldaek
commented
Sep 12, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15680 |
| License | MIT |
| Doc PR |
| $verbosity = self::VERBOSITY_VERY_VERBOSE; | ||
| } elseif ($options & self::VERBOSITY_DEBUG) { | ||
| $verbosity = self::VERBOSITY_DEBUG; | ||
| } |
There was a problem hiding this comment.
these if/elseif statements can be simplified significantly:
$typeCheck = self::OUTPUT_NORMAL | self::OUTPUT_RAW | self::OUTPUT_PLAIN;
$type = $typeCheck & $options ?: self::OUTPUT_NORMAL;
$verbosity = ~$typeCheck & $options ?: self::VERBOSITY_NORMAL;or (less dynamic):
$type = 7 & $options ?: self::OUTPUT_NORMAL;
$verbosity = -8 & $options ?: self::VERBOSITY_NORMAL;There was a problem hiding this comment.
Yup that's a good point, thanks. I implemented it with a fully explicit version for both types and verbosities though just so the code is more clear.
… passed in as well
a9050a4 to
749fba5
Compare
|
👍 Status: Reviewed |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @Seldaek. |
fabpot
added a commit
that referenced
this pull request
Sep 13, 2015
…erbosity can be passed in as well (Seldaek) This PR was merged into the 2.8 branch. Discussion ---------- Convert Output::write's type to an options arg where verbosity can be passed in as well | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15680 | License | MIT | Doc PR | Commits ------- 749fba5 Convert Output::write's type to an options arg where verbosity can be passed in as well
fabpot
added a commit
that referenced
this pull request
Sep 13, 2015
…ixes #15680 (Seldaek) This PR was merged into the 2.8 branch. Discussion ---------- Make the exception output visible even in quiet mode, fixes #15680 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15680 | License | MIT | Doc PR | This builds upon #15772 and sets the exception output in Application::renderException to use VERBOSITY_QUIET so that exceptions are always visible. IMO it's a good change but I can see that it is potentially controversial. Commits ------- e9ee8f5 Make the exception output visible even in quiet mode, fixes #15680
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.