[WIP] Better exception page #15792
Closed
[WIP] Better exception page #15792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hason
commented
Sep 14, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | |
| Fixed tickets | |
| License | MIT |
| Doc PR |
- add twig files into stack trace
- add syntax highlighters for PHP and Twig with symfony.com's color scheme (reuse from [WIP][DX] Better exception page #12363)
- use VarDumper for function arguments
- improve style of exception page (assistance from @javiereguiluz ?)
4 tasks
| <tag name="exception.processor" /> | ||
| </service> | ||
|
|
||
| <service id="debug.arguments_processor" class="Symfony\Component\Debug\ArgumentsFlattenExceptionProcessor" public="false"> |
There was a problem hiding this comment.
I would name them debug.exception_processor.* instead, to group related services
3e53160 to
cae0933
Compare
| use Symfony\Component\DependencyInjection\Reference; | ||
|
|
||
| /** | ||
| * Registers the code highlighters. |
|
nice work 👍 |
| * | ||
| * @param array $trace The trace | ||
| */ | ||
| public function replaceTrace($trace) |
There was a problem hiding this comment.
what about adding an array type hint instead of casting to (array)?
|
@hason Any updates? |
|
Closing as there is no recent update and many comments that would need to be fixed. It does not apply cleanly either. @hason Feel free to reopen a new PR on master when you have time. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.