Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] fixed cursor as pointer when hovering over link. #15814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2015

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets ~
Tests pass? yes
License MIT

@stof
Copy link
Member

stof commented Sep 16, 2015

Please also add the e.preventDefault() in

if (!toggle.hasAttribute('data-toggle-alt-content')) {
before the early return, otherwise this case will make the page scroll to the top.

@stloyd
Copy link
Contributor

stloyd commented Sep 16, 2015

Maybe better would be replace that <a> with <button>?

@stof
Copy link
Member

stof commented Sep 16, 2015

this would force to add a bunch of CSS to reset the styles (we don't want a huge button here), but it would be more semantic markup indeed.

@aitboudad aitboudad force-pushed the webprofiler_pointer_link_fix branch from 3d466de to ac7591f Compare September 16, 2015 12:52
@aitboudad
Copy link
Contributor Author

switched into button

@fabpot
Copy link
Member

fabpot commented Sep 22, 2015

ping @symfony/deciders @javiereguiluz

@stof
Copy link
Member

stof commented Sep 22, 2015

👍

@fabpot
Copy link
Member

fabpot commented Sep 22, 2015

Thank you @aitboudad.

@fabpot fabpot merged commit ac7591f into symfony:2.8 Sep 22, 2015
fabpot added a commit that referenced this pull request Sep 22, 2015
…g over link. (aitboudad)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] fixed cursor as pointer when hovering over link.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | ~
| Tests pass?   | yes
| License       | MIT

Commits
-------

ac7591f [WebProfilerBundle] added btn-link.
@aitboudad aitboudad deleted the webprofiler_pointer_link_fix branch September 22, 2015 14:11
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
…hovering over link. (aitboudad)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] fixed cursor as pointer when hovering over link.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | ~
| Tests pass?   | yes
| License       | MIT

Commits
-------

ac7591f [WebProfilerBundle] added btn-link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants