[Security] Improve deprecation logic to minimalize the changes required in 3.0 #15886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Sep 24, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -146,6 +139,6 @@ protected function isGranted($attribute, $object, $user = null) | |||
| */ | |||
| protected function voteOnAttribute($attribute, $object, TokenInterface $token) | |||
| { | |||
| return false; | |||
| return $this->isGranted($attribute, $object, $token->getUser()); | |||
There was a problem hiding this comment.
Can we not move the trigger_error here as well? Then we don't need reflection at all.
There was a problem hiding this comment.
Hm classes that don't support any attributes would not trigger a warning then.
|
👍 |
1 similar comment
|
👍 |
|
you should also add a deprecation warning in |
|
@stof I don't like that, as bundles supporting 2.7 and 2.8 will probably create both methods and call |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.