[DomCrawler] Deprecate methods inherited from SplObjectStorage #15907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All inherited methods are deprecated, except a few ones:
|
| */ | ||
| public function detach($object) | ||
| { | ||
| @trigger_error('The method '.__METHOD__.' is deprecated as of 2.8 and will be removed in 3.0.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
We are using The __METHOD__ method in triggers. Should be changed everywhere here.
|
Should we now implement the desired interfaces explicitly so that we are aware of the fact that we need to ship custom implementations once we break the inheritance? Status: Needs work |
|
@xabbuh the only interfaces we need at Traversable and Countable. And we will notice it when rewriting the implementation, because most tests of the crawler are relying on them anyway. |
c082ddc to
997c650
Compare
|
Updated. Status: needs review |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2015
…tStorage (stof) This PR was merged into the 2.8 branch. Discussion ---------- [DomCrawler] Deprecate methods inherited from SplObjectStorage | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | half of #15849 | License | MIT | Doc PR | n/a There is no documentation change to be done for it: we don't document the fact that DomCrawler extends SplObjectStorage (this is an implementation detail which leaked because of using inheritance rather than composition). Commits ------- 997c650 Deprecate methods inherited from SplObjectStorage
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 19, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5796). Discussion ---------- Fix for #5783 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8 | Fixed tickets | #5783 I can confirm, that this is the only place where the `SplStorageObject` and its methods which were marked as deprecated in symfony/symfony#15907 are referenced. Commits ------- 065d28c Fix for #5783
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no documentation change to be done for it: we don't document the fact that DomCrawler extends SplObjectStorage (this is an implementation detail which leaked because of using inheritance rather than composition).