Detect Mintty for color support on Windows #15915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mintty is now the default terminal in GitBash, and it supports ANSI colors without the need of ANSICON (it even supports 256 colors rather than the 16 colors supported by ANSICON).
|
Note that Mintty is used in Cygwin, so this would mean that Cygwin users get colored output for free now, without the need to use a second tool handling colors just to make the color support detected (or to pass |
This was referenced Sep 26, 2015
|
Sounds like a bug to me, should be merged in 2.3 instead. |
|
👍 (also to merge this into the |
|
Status: Reviewed |
|
Thank you @stof. |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 3, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5726). Discussion ---------- Document the support of Mintty for colors | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes symfony/symfony#15915 | Applies to | 2.8+ (or 2.3+ depending on where it gets merged) | Fixed tickets | n/a Commits ------- d8d4345 Document the support of Mintty for colors
This was referenced Oct 27, 2015
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mintty is now the default terminal in GitBash, and it supports ANSI colors without the need of ANSICON (it even supports 256 colors rather than the 16 colors supported by ANSICON).
I submitted it to 2.8 as it can be considered as a new feature. But it should not be hard to merge it in other branches if we decide to consider it as a bugfix (it just needs to be split because VarDumper does not exist in 2.3)