Support "!!binary" syntax (decodes base64 string). #15958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supported in folded-scalar (lines ending with | or >) form, or inline form.
| $modifiers = isset($matches['modifiers']) ? $matches['modifiers'] : ''; | ||
|
|
||
| return $this->parseFoldedScalar($matches['separator'], preg_replace('#\d+#', '', $modifiers), (int) abs($modifiers)); | ||
| $output = $this->parseFoldedScalar($matches['separator'], preg_replace('#\d+#', '', $modifiers), (int) abs($modifiers)); | ||
| if (isset($matches['tag']) && $matches['tag'] == '!!binary') |
|
Tests covering this case are missing. Status: needs work |
|
@johnnytemp Can you finish this one? |
|
@fabpot I am not familiar with the project. Tried, and find it hard to master the test tools. So, sorry, I won't do it currently. |
|
@johnnytemp Thanks for the feedback. I'll finish this for you then. |
|
Closing in favor of #17599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was submitted on the symfony/yaml read-only repository by @johnnytemp and moved automatically to the main Symfony repository (closes symfony/yaml#13).
Only supported in folded-scalar (lines ending with | or >) form, or inline form.
Example Yaml:
items