added logging of unused tags #15963
Merged
added logging of unused tags #15963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during container compilation
| $tags = array_values(array_diff($this->findTags(), $this->usedTags)); | ||
| $tags = array_unique($tags); | ||
|
|
||
| return $tags; |
There was a problem hiding this comment.
return array_unique($tags) (overwriting variables usually not nice)
There was a problem hiding this comment.
actually, the array_unique is useless because findTags already ensures that
|
IMO it's enough to add the |
| * @var array | ||
| */ | ||
| protected $whitelist = array( | ||
| "console.command", |
9dcab2b to
2054135
Compare
|
Indeed, the pass is now only enabled on debug. That makes sense as the compile log is only dumped in debug mode anyway. Should be ready now. |
| /** | ||
| * Returns all tags not queried by findTaggedServiceIds | ||
| * | ||
| * @return array An array of tags |
There was a problem hiding this comment.
lets use string[] to be more specific
|
👍 Status: Reviewed |
|
Thank you @Marmelatze. |
fabpot
added a commit
that referenced
this pull request
Sep 28, 2015
This PR was merged into the 2.8 branch. Discussion ---------- added logging of unused tags | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11511, #11744 | License | MIT | Doc PR | - This is the same as #11744 but with some minor tweaks and some unit tests for the compiler pass. Commits ------- 95c9f50 added some tests d3271e1 missing tags in whitelist f51fe4a [FrameworkBundle] [DependencyInjection] added logging of unused tags during container compilation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #11744 but with some minor tweaks and some unit tests for the compiler pass.